From 9eae0d1a95365fff86718e4ffb5f12664f7e9157 Mon Sep 17 00:00:00 2001 From: filifa Date: Sat, 5 Apr 2025 17:57:00 -0400 Subject: [PATCH] adjust error handling --- cmd/root.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/cmd/root.go b/cmd/root.go index 865f4b5..d2d3ae3 100644 --- a/cmd/root.go +++ b/cmd/root.go @@ -22,6 +22,7 @@ import ( "go/ast" "go/parser" "go/token" + "log" "os" "path/filepath" @@ -106,7 +107,7 @@ func constructDependencyGraph(typesUsed map[filename][]typename, declaredAt map[ declFile, ok := declaredAt[t] if !ok { - return nil, errors.New(string(t) + " not found") + return nil, errors.New("did not find declaration for " + string(t)) } if fname == declFile { @@ -130,7 +131,7 @@ func parse(cmd *cobra.Command, args []string) { fset := token.NewFileSet() pkgs, err := parser.ParseDir(fset, pkg, nil, 0) if err != nil { - panic(err) + log.Fatal(err) } typesUsed := make(map[filename][]typename) @@ -174,13 +175,12 @@ func parse(cmd *cobra.Command, args []string) { depGraph, err := constructDependencyGraph(typesUsed, declaredAt, ignores) if err != nil { - // TODO: handle this error better - panic(err) + log.Fatal(err) } viz, err := dot.Marshal(depGraph, "deps", "", "\t") if err != nil { - panic(err) + log.Fatal(err) } fmt.Println(string(viz))