diff --git a/sql/appearances.sql b/sql/appearances.sql index 082af8d..f4b6436 100644 --- a/sql/appearances.sql +++ b/sql/appearances.sql @@ -15,6 +15,8 @@ this program. If not, see . */ pragma foreign_keys = 0; +-- check constraints are disabled for this file because the G_of constraint fails for a lot of records and i don't feel like correcting it right now +pragma ignore_check_constraints = 1; begin; attach database 'lahman-raw.db' as 'raw'; @@ -122,8 +124,7 @@ CREATE TABLE IF NOT EXISTS "appearances" ( "G_lf" NUMERIC check ("G_lf" <= "G_all"), "G_cf" NUMERIC check ("G_cf" <= "G_all"), "G_rf" NUMERIC check ("G_rf" <= "G_all"), - -- there should be a G_of <= G_all constraint, but there's a lot of rows that fail and i don't feel like correcting them right now - "G_of" NUMERIC, + "G_of" NUMERIC check ("G_of" <= "G_all"), "G_dh" NUMERIC check ("G_dh" <= "G_all"), "G_ph" NUMERIC check ("G_ph" <= "G_all"), "G_pr" NUMERIC check ("G_pr" <= "G_all"), diff --git a/sql/halloffame.sql b/sql/halloffame.sql index dfdf5fb..0c37a2c 100644 --- a/sql/halloffame.sql +++ b/sql/halloffame.sql @@ -15,6 +15,8 @@ this program. If not, see . */ pragma foreign_keys = 0; +-- checks are disabled because there's a check for if inducted is Y or N, but there are too many rows i don't feel like correcting right now +pragma ignore_check_constraints = 1; begin; attach database 'lahman-raw.db' as 'raw'; @@ -44,8 +46,7 @@ CREATE TABLE IF NOT EXISTS main."halloffame" ( "ballots" TEXT, "needed" TEXT, "votes" NUMERIC, - -- we could have a check for if inducted is Y or N, but there are too many rows i don't feel like correcting right now - "inducted" TEXT, + "inducted" TEXT check ("inducted" in ('Y','N')), "category" TEXT, "needed_note" text, PRIMARY KEY("player","year","votedBy")